Skip to content

Commit ac189cf

Browse files
committed
refactor(rviz): reuse shared overlay utility
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1 parent 7a3a17f commit ac189cf

5 files changed

Lines changed: 7 additions & 299 deletions

File tree

autoware_overlay_rviz_plugin/autoware_topic_text_overlay_rviz_plugin/package.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
<depend>autoware_internal_debug_msgs</depend>
1717
<depend>pluginlib</depend>
1818
<depend>rclcpp</depend>
19+
<depend>rviz_2d_overlay_msgs</depend>
20+
<depend>rviz_2d_overlay_plugins</depend>
1921
<depend>rviz_common</depend>
2022
<depend>rviz_ogre_vendor</depend>
2123
<depend>rviz_rendering</depend>

autoware_overlay_rviz_plugin/autoware_topic_text_overlay_rviz_plugin/src/jsk_overlay_utils.cpp

Lines changed: 0 additions & 172 deletions
This file was deleted.

autoware_overlay_rviz_plugin/autoware_topic_text_overlay_rviz_plugin/src/jsk_overlay_utils.hpp

Lines changed: 0 additions & 122 deletions
This file was deleted.

autoware_overlay_rviz_plugin/autoware_topic_text_overlay_rviz_plugin/src/topic_text_overlay_panel.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <QTimer>
2929
#include <QVBoxLayout>
3030
#include <pluginlib/class_list_macros.hpp>
31+
#include <rviz_rendering/render_system.hpp>
3132

3233
#include <autoware_internal_debug_msgs/msg/bool_stamped.hpp>
3334
#include <autoware_internal_debug_msgs/msg/float32_multi_array_stamped.hpp>
@@ -240,8 +241,8 @@ void TopicTextOverlayPanel::onInitialize()
240241
static int count = 0;
241242
std::ostringstream overlay_name;
242243
overlay_name << "TopicTextOverlayPanelObject" << count++;
243-
overlay_ = std::make_shared<OverlayObject>(
244-
getDisplayContext()->getSceneManager(), raw_node_->get_logger(), overlay_name.str());
244+
rviz_rendering::RenderSystem::get()->prepareOverlays(getDisplayContext()->getSceneManager());
245+
overlay_ = std::make_shared<rviz_2d_overlay_plugins::OverlayObject>(overlay_name.str());
245246
overlay_->show();
246247

247248
refreshTopics();

autoware_overlay_rviz_plugin/autoware_topic_text_overlay_rviz_plugin/src/topic_text_overlay_panel.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@
1515
#ifndef AUTOWARE_TOPIC_TEXT_OVERLAY_RVIZ_PLUGIN__TOPIC_TEXT_OVERLAY_PANEL_HPP_
1616
#define AUTOWARE_TOPIC_TEXT_OVERLAY_RVIZ_PLUGIN__TOPIC_TEXT_OVERLAY_PANEL_HPP_
1717

18-
#include "jsk_overlay_utils.hpp"
19-
2018
#include <QColor>
2119
#include <rclcpp/rclcpp.hpp>
20+
#include <rviz_2d_overlay_plugins/overlay_utils.hpp>
2221
#include <rviz_common/config.hpp>
2322
#include <rviz_common/display_context.hpp>
2423
#include <rviz_common/panel.hpp>
@@ -107,7 +106,7 @@ private Q_SLOTS:
107106

108107
rviz_common::ros_integration::RosNodeAbstractionIface::WeakPtr rviz_ros_node_;
109108
rclcpp::Node::SharedPtr raw_node_;
110-
OverlayObject::Ptr overlay_;
109+
rviz_2d_overlay_plugins::OverlayObject::SharedPtr overlay_;
111110

112111
QCheckBox * enable_overlay_;
113112
QListWidget * topic_list_;

0 commit comments

Comments
 (0)