Skip to content
This repository was archived by the owner on Mar 28, 2025. It is now read-only.

Commit ae59407

Browse files
committed
chore(nebula_node_container): make launchers work with Nebula v0.2.0
Signed-off-by: Max SCHMELLER <[email protected]>
1 parent fcc7cde commit ae59407

File tree

1 file changed

+8
-37
lines changed

1 file changed

+8
-37
lines changed

common_sensor_launch/launch/nebula_node_container.launch.py

+8-37
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,18 @@ def create_parameter_dict(*args):
109109
nodes.append(
110110
ComposableNode(
111111
package="nebula_ros",
112-
plugin=sensor_make + "DriverRosWrapper",
113-
name=sensor_make.lower() + "_driver_ros_wrapper_node",
112+
plugin=sensor_make + "RosWrapper",
113+
name=sensor_make.lower() + "_ros_wrapper_node",
114114
parameters=[
115115
{
116116
"calibration_file": sensor_calib_fp,
117117
"sensor_model": sensor_model,
118+
"launch_hw": LaunchConfiguration("launch_driver"),
118119
**create_parameter_dict(
119120
"host_ip",
120121
"sensor_ip",
121122
"data_port",
123+
"gnss_port",
122124
"return_mode",
123125
"min_range",
124126
"max_range",
@@ -127,6 +129,9 @@ def create_parameter_dict(*args):
127129
"cloud_min_angle",
128130
"cloud_max_angle",
129131
"dual_return_distance_threshold",
132+
"rotation_speed",
133+
"packet_mtu_size",
134+
"setup_sensor",
130135
),
131136
},
132137
],
@@ -235,41 +240,7 @@ def create_parameter_dict(*args):
235240
output="both",
236241
)
237242

238-
driver_component = ComposableNode(
239-
package="nebula_ros",
240-
plugin=sensor_make + "HwInterfaceRosWrapper",
241-
# node is created in a global context, need to avoid name clash
242-
name=sensor_make.lower() + "_hw_interface_ros_wrapper_node",
243-
parameters=[
244-
{
245-
"sensor_model": sensor_model,
246-
"calibration_file": sensor_calib_fp,
247-
**create_parameter_dict(
248-
"sensor_ip",
249-
"host_ip",
250-
"scan_phase",
251-
"return_mode",
252-
"frame_id",
253-
"rotation_speed",
254-
"data_port",
255-
"gnss_port",
256-
"cloud_min_angle",
257-
"cloud_max_angle",
258-
"packet_mtu_size",
259-
"dual_return_distance_threshold",
260-
"setup_sensor",
261-
),
262-
}
263-
],
264-
)
265-
266-
driver_component_loader = LoadComposableNodes(
267-
composable_node_descriptions=[driver_component],
268-
target_container=container,
269-
condition=IfCondition(LaunchConfiguration("launch_driver")),
270-
)
271-
272-
return [container, driver_component_loader]
243+
return [container]
273244

274245

275246
def generate_launch_description():

0 commit comments

Comments
 (0)