-
Notifications
You must be signed in to change notification settings - Fork 840
[tmpnet] Enable monitoring of nodes running in kube #3794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac5339c to
b742fdd
Compare
b742fdd to
fc2cc0c
Compare
d9a5f75 to
ae72771
Compare
5875349 to
1e699cf
Compare
1e699cf to
5ee084c
Compare
18ce850 to
42e7450
Compare
d87b8bf to
9c6ef9e
Compare
42e7450 to
053bfc5
Compare
053bfc5 to
2f49e50
Compare
ae652fa to
717cad1
Compare
717cad1 to
8932fa3
Compare
8932fa3 to
f710299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Enables deployment and testing of Prometheus and Promtail collectors in a local Kind cluster via tmpnetctl start-kind-cluster, wiring new flags through CLI, tests, and Kubernetes manifests.
- Introduce
CollectorVarsto register--start-metrics-collectorand--start-logs-collectorflags and corresponding test checks - Add YAML manifests for Promtail DaemonSet and Prometheus Agent StatefulSet
- Integrate
DeployKubeCollectorsintoStartKindClusterand propagate monitoring labels inNewNodeStatefulSet
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/upgrade/upgrade_test.go | Swap individual bool flags for unified CollectorVars |
| tests/fixture/tmpnet/yaml/promtail-daemonset.yaml | Add Promtail DaemonSet manifest |
| tests/fixture/tmpnet/yaml/prometheus-agent.yaml | Add Prometheus Agent StatefulSet manifest |
| tests/fixture/tmpnet/tmpnetctl/main.go | Wire CollectorVars into start-kind-cluster command |
| tests/fixture/tmpnet/start_kind_cluster.go | Update StartKindCluster signature and invoke DeployKubeCollectors |
| tests/fixture/tmpnet/monitor_kube.go | Implement DeployKubeCollectors and helper functions |
| tests/fixture/tmpnet/kube_runtime.go | Pass monitoring labels to node runtime |
| tests/fixture/tmpnet/kube.go | Extend NewNodeStatefulSet to apply labels and annotations |
| tests/fixture/tmpnet/flags/collector.go | Define CollectorVars and flag registration |
| tests/fixture/tmpnet/README.md | Document new flags and YAML directory |
| scripts/start_kind_cluster.sh | Propagate new start flags in helper script |
Co-authored-by: Copilot <[email protected]> Signed-off-by: maru <[email protected]>
Co-authored-by: Elvis <[email protected]> Signed-off-by: maru <[email protected]>
Co-authored-by: Elvis <[email protected]> Signed-off-by: maru <[email protected]>
Co-authored-by: Elvis <[email protected]> Signed-off-by: maru <[email protected]>
PR Chain: tmpnet+kube
This PR chain enables tmpnet to deploy temporary networks to Kubernetes. Early PRs refactor tmpnet to support the addition in #3615 of a new tmpnet node runtime for kube.
Why this should be merged
How this works
tmpnetctl start-kind-cluster --start-metrics-collector --start-logs-collectorHow this was tested
CI configures a metrics check to verify that logs and metrics were collected
Need to be documented in RELEASES.md?
N/A
TODO