feat: (pvm, avm, info) CP-9758 cleanup. WIP#958
Merged
erictaylor merged 8 commits intomasterfrom Feb 5, 2025
Merged
Conversation
rictorlome
reviewed
Feb 3, 2025
Collaborator
rictorlome
left a comment
rictorlome
left a comment
There was a problem hiding this comment.
This is a backwards breaking change, let's make a major bump for this next release
rictorlome
reviewed
Feb 3, 2025
Collaborator
rictorlome
left a comment
rictorlome
left a comment
There was a problem hiding this comment.
A few more follow ups, thank you!
src/utils/validateBurnedAmount/validateStaticBurnedAmount.test.ts
Outdated
Show resolved
Hide resolved
erictaylor
requested changes
Feb 4, 2025
Member
erictaylor
left a comment
erictaylor
left a comment
There was a problem hiding this comment.
Looking great @frichards! Thank you so much for working on this!
Couple of comments.
Additionally, I think we should maybe go ahead and nuke the original p-chain examples, and move the examples/p-chain/etna files into examples/p-chain. Make sure any "scripts" in package.json are appropriately updated as well.
erictaylor
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an WIP branch.