fix(console): l1 upgrade builder follow-ups — chain-driven state, bundled predeploys, no snapshots#4294
Open
anishnar wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4276 (
feat/l1-upgrade-json-builder) — final fixes for the L1 upgrade builder so testing can continue on this branch's preview without churning the base PR.Fixes
Managed/self-hosted detection is server-authoritative
GET /api/console/l1-upgrade/managed(NodeRegistration table); the query-param hint and dashboard match are only in-flight fallbacks.mode=detectskips the node-service round-trip on the select step; the GET reportsmanaged: true+serviceErrorinstead of a 5xx when reading the node's file fails.eth_getActiveRulesAtfallbacketh_getActiveRulesAt. The RPC route now derives active precompiles frometh_getChainConfig(genesis configs +upgrades.precompileUpgradesreplayed up to the latest block) and only surfaces an error when both methods fail. No more error banner on hosted RPCs.Predeploy presets bundle their bytecode
Snapshots removed; the chain itself is the source of truth
chainConfig.upgradesover RPC → empty.L1UpgradeSnapshotprisma model/migration left in place to avoid migrate drift on the preview DB — can be dropped before merge.Also carries the earlier round of fixes: structural validation of pasted/imported upgrade.json, Add Wallet prompting the wallet connect flow when disconnected, native minter (and all active allowlist precompiles) getting an "Update Allowlist" path that generates the documented disable + re-enable pair, and the source contract preset dropdown.
Verification
tests/unit), including new coverage forderiveActivePrecompiles,extractUpgradeJsonFromChainConfig, storage in stateUpgrades, update-pair generation, and upgrade.json structure validation.tsc --noEmitand eslint clean.next dev): managed/self-hosted/check-failed apply states, snapshot UI removal, base prefill from chainConfig, preset bytecode + storage fill, validation errors, one-click apply through write→restart→success, Add Wallet connect prompt.eth_getActiveRulesAtbanner, Native Minter / Fee Manager / Warp show Active via the chainConfig fallback, and the base upgrade.json prefills with Dispatch's actualfeeManagerConfigupgrade.