Allows P-chain to sign off on updates to L1 validator sets#1330
Merged
Conversation
mdelle1
requested review from
SavalaBee,
batconjurer,
geoff-vball,
iansuvak and
ylg-avalabs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+79
to
+83
| require( | ||
| signingChainID == pChainID | ||
| || (signingChainID == payloadBlockchainID && isRegistered(payloadBlockchainID)), | ||
| "Invalid signing chain" | ||
| ); |
Comment on lines
+79
to
+83
| require( | ||
| signingChainID == pChainID | ||
| || (signingChainID == payloadBlockchainID && isRegistered(payloadBlockchainID)), | ||
| "Invalid signing chain" | ||
| ); |
geoff-vball
approved these changes
May 22, 2026
batconjurer
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR both removes
updateValidatorSet, which was a redundant call and could be encapsulated byregisterValidatorSetwith minimal modifications, and makes progress on the contract-side of Issue #1324 allowing the P-chain, being the source of truth, to sign off on updates to any L1 validator set update.