Add macro key for overriding the int type used in (de)serializing#1332
Draft
batconjurer wants to merge 8 commits into
Draft
Add macro key for overriding the int type used in (de)serializing#1332batconjurer wants to merge 8 commits into
batconjurer wants to merge 8 commits into
Conversation
batconjurer
requested review from
SavalaBee,
geoff-vball,
iansuvak,
mdelle1 and
ylg-avalabs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function packDynamicStruct(DynamicStruct memory obj) public pure returns (bytes memory) { | ||
| bytes memory Addresses_bytes; | ||
| Addresses_bytes = abi.encodePacked(uint32(obj.Addresses.length)); | ||
| for (uint256 i_0 = 0; i_0 < obj.Addresses.length;) { |
batconjurer
force-pushed
the
bat/test-reforge-pipeline
branch
from
615fb2c to
ab43fca
Compare
batconjurer
force-pushed
the
bat/test-reforge-pipeline
branch
from
ab43fca to
d1f044a
Compare
batconjurer
force-pushed
the
bat/add-length-type-opt-macros
branch
from
608eab5 to
6edf09b
Compare
geoff-vball
approved these changes
Jun 2, 2026
batconjurer
force-pushed
the
bat/test-reforge-pipeline
branch
2 times, most recently
from
73c33b2 to
3852d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Before this, when serializing arrays, the length was always encoded via a uint256. This is not compatible with some of our existing hand-rolled serialization methods, so this fixes that by allowing a length type override.
How this works
How this was tested
How is this documented