Added support for asserts on deserialized data#1346
Draft
batconjurer wants to merge 1 commit into
Draft
Conversation
geoff-vball
approved these changes
Jun 2, 2026
ylg-avalabs
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #1334
Adds assert post-conditions to the #[unpack(...)] macro. Three forms are supported:
Multiple assert keys may appear on a single annotation. The closure value is a quoted string so commas and = signs inside the expression are not misinterpreted as argument separators. each is rejected at the type level and on non-container fields with a descriptive error.
The multi-line comment parser was also fixed: reforge::get_comment concatenates comment lines without newlines, so strip_comment_prefixes now splits on embedded // occurrences (outside quoted strings) in addition to \n.
How this works
How this was tested
How is this documented