This repository was archived by the owner on Jun 9, 2026. It is now read-only.
test: support eth_*Filter RPCs #136
Merged
Merged
Conversation
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
JonathanOppenheimer
added
the
DO NOT MERGE
JonathanOppenheimer
changed the title
eth_filters RPCs
JonathanOppenheimer
changed the title
eth_filters RPCs eth_filter RPCs
JonathanOppenheimer
changed the title
eth_filter RPCs eth_*filter RPCs
JonathanOppenheimer
changed the title
eth_*filter RPCs eth_*Filter RPCs
alarso16
reviewed
Feb 2, 2026
JonathanOppenheimer
removed
the
DO NOT MERGE
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/filter-apis
branch
from
ed5984a to
11993db
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/filter-apis
branch
from
11993db to
0491434
Compare
JonathanOppenheimer
changed the base branch from
main
to
alarso16/rpc-test-err
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/filter-apis
branch
from
0491434 to
57135e8
Compare
ARR4N
previously requested changes
Feb 24, 2026
ARR4N
left a comment
ARR4N
left a comment
Collaborator
There was a problem hiding this comment.
I don't love the way eventually works but can't think of an easy fix. There are some other changes necessary so I've shared them while I experiment.
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/filter-apis
branch
from
b95e626 to
7185099
Compare
ARR4N
reviewed
Feb 25, 2026
ARR4N
reviewed
Feb 25, 2026
ARR4N
reviewed
Feb 25, 2026
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
JonathanOppenheimer
dismissed
ARR4N’s stale review
I believe these are stale, let me know if you still have changes!
StephenButtolph
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the standard Ethereum JSON-RPC filter APIs:
eth_newFilter- Create log filter with optional criteria (address, topics)eth_newBlockFilter- Create filter for new blockseth_newPendingTransactionFilter- Create filter for pending transactionseth_getFilterChanges- Poll for new events since last polleth_getFilterLogs- Get all logs matching a filtereth_uninstallFilter- Remove a filterThis should not be merged until after #157 is merged.