RFC: Demonstration of http2-jetty, http3-jetty & http2-robaho#331
Draft
mechite wants to merge 2 commits intoavaje:masterfrom
Draft
RFC: Demonstration of http2-jetty, http3-jetty & http2-robaho#331mechite wants to merge 2 commits intoavaje:masterfrom
http2-jetty, http3-jetty & http2-robaho#331mechite wants to merge 2 commits intoavaje:masterfrom
Conversation
Signed-off-by: Mahied Maruf <contact@mechite.com>
Collaborator
Author
|
If in the Jetty one, we don't use This seems trivial to do EDIT — I will probably work on this more later, but I'm quite busy ATM |
Collaborator
|
yeah the jetty spi is nonfunctional with http2/http3 atm |
Collaborator
Author
|
@SentryMan what kind of test do we even write here?
if you have any idea feel free to put a trivial test even if it fails |
Collaborator
|
the robaho one is so simple I don't think we need a test, for jetty, what's needed is to make even a basic get call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SentryMan
Related-to: #46
Signed-off-by: Mahied Maruf contact@mechite.com