Add cleanup hook helpers#3447
Closed
Cosmhyccc wants to merge 2 commits into
Closed
Conversation
Member
|
We don't accept fully AI-generated PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
Summary
test.cleanup()andtest.cleanupEach()hook chains, includingtest.serialvariants.before+after.always, andbeforeEach+afterEach.always.Verification
PATH=/Users/saifali/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx tsc --noEmitPATH=/Users/saifali/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH npx tap test-tap/hooks.jsLint source filespassed after the switch refactor.