Replaced "::=" with ":=" #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "::=" syntax is POSIX and ":=" is not, which is probably why we went with "::=" before. However, GNU Make also supports ":=", and has done so for a longer time than "::=". I have already encountered one machine with such an old version of make that "::=" was not supported, but ":=" was. Hence this change. If we already use any GNU Make-specific features, which we probably do, this change only improves portability. See also: https://stackoverflow.com/questions/37206926/for-immediate-variable-assignment-double-colon-or-one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure whether this is an improvement or not. Please see the commit message for the tradeoffs.
The machine I'm talking about is the DAS-5 (https://www.cs.vu.nl/das5/), by the way.