Lookup updates #109
Closed
Lookup updates #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias; added support functions and property aliases; minor refactoring
Owner
|
It looks like these are mostly changes related to #108. I do see one commit touching lookup.py. About that: lookup.py is pretty much deprecated, see #99, #61, #83. I can't officially mark it as deprecated yet, since there are a few functions in there that we do need to keep (I'll sort that out after #110), but I won't merge changes to lookup.py anymore. I'm closing this PR, since it seems like all changes apart from the lookup ones should probably go to #108. |
Collaborator
Author
|
Oh yes, I wasn't being careful and the changes related to #108 shouldn't been in here. I'll be more careful next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of tweak-as-you-go updates to lookup. Keeping it as a draft for now, just in case something else pops up.