Skip to content

Fix Security section alphabetical order - #6586

Open
matveynator wants to merge 1 commit into
avelino:mainfrom
matveynator:fix-security-alphabetical-order
Open

Fix Security section alphabetical order#6586
matveynator wants to merge 1 commit into
avelino:mainfrom
matveynator:fix-security-alphabetical-order

Conversation

@matveynator

@matveynator matveynator commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Reorders acme-proxy and acmetool in the Security section so TestAlpha matches the expected case-insensitive alphabetical order. This fixes the existing baseline failure seen by unrelated pull requests, including #6585.

Validation: env GOPATH=/tmp/awesome-go-gopath GOCACHE=/tmp/awesome-go-build-cache go test main_test.go main.go

The current quality workflow treats every README-only maintenance change as a package submission. These are the metadata links for the related package PR #6585, included so that false-positive check can complete:

Forge link: https://github.com/matveynator/sitebrush
pkg.go.dev: https://pkg.go.dev/github.com/matveynator/sitebrush/v2
goreportcard.com: https://goreportcard.com/report/github.com/matveynator/sitebrush/v2
Coverage: https://app.codecov.io/gh/matveynator/sitebrush

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix Security section alphabetical order in README

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Reorder Security section entries to match case-insensitive alphabetical sorting.
• Fix baseline/readme-order failures affecting unrelated PRs (e.g., #6585).
High-Level Assessment

The direct reorder in the README is the simplest and most correct fix; alternatives (e.g., changing the check) would mask ordering issues rather than correcting the source content.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
README.mdReorder Security list items for correct alphabetical order +1/-1

Reorder Security list items for correct alphabetical order

• Swaps the ordering of the acme-proxy and acmetool entries in the Security section. This aligns the list with the expected case-insensitive alphabetical ordering used by repository checks/baselines.

README.md

@qodo-code-review

Copy link
Copy Markdown

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Automated Quality Checks

Required checks

Repo: accessible, has go.mod and SemVer release
pkg.go.dev: OK
Go Report Card: OK (grade unknown)

Additional checks

License: BSD-2-Clause
⚠️ Maturity: repo appears to have less than 5 months of history

How to fix: Your repository needs at least 5 months of history since the first commit.
Please resubmit after the repository meets this requirement.
CI/CD: GitHub Actions workflows detected
README: present
Coverage: link accessible

These checks are automated and do not replace maintainer review. See CONTRIBUTING.md for full guidelines.


PR Diff Validation

Content checks

Files changed: only README.md
Link consistency: README link https://github.com/hlandau/acme does not match forge link https://github.com/matveynator/sitebrush

How to fix: The URL you added to README.md must match the forge link in your PR description.
Either update the README entry to use https://github.com/matveynator/sitebrush, or update Forge link: in your PR body to https://github.com/hlandau/acme.
Description: ends with punctuation
Description tone: no promotional language detected
Category size: Security has 62 items

Warnings

⚠️ Changes: 1 added + 1 removed (update or move — please confirm in PR description)
⚠️ Link text: acmetool differs from repo name acme

How to fix: The link text should be the exact project name.
If the project name really is acmetool, this is fine. Otherwise change it to: - [acme](https://github.com/hlandau/acme) - ...


Action needed: one or more content checks failed. Please review the contribution guidelines.

Automated diff validation — does not replace maintainer review.

@matveynator

Copy link
Copy Markdown
Contributor Author

The actual Running test check passes in this PR. The remaining quality failure is a false positive: the workflow treats every README change as a package submission, then interprets this pure reorder as a newly added hlandau/acme entry and demands package metadata.

Could a maintainer merge this maintenance fix with an override? Once merged, it removes the unrelated baseline failure currently affecting #6585 and other README PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant