Skip to content

Fix Security section alphabetical order - #6591

Open
matveynator wants to merge 1 commit into
avelino:mainfrom
matveynator:fix-security-tools-order
Open

Fix Security section alphabetical order#6591
matveynator wants to merge 1 commit into
avelino:mainfrom
matveynator:fix-security-tools-order

Conversation

@matveynator

Copy link
Copy Markdown
Contributor

Fix the pre-existing TestAlpha failure on main by restoring alphabetical order in the Security section: acme-proxy must precede acmetool.

This maintenance fix is intentionally separate from #6590 so that the package submission continues to change exactly one item.

Validation: go test main_test.go main.go

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@github-actions

Copy link
Copy Markdown

Automated Quality Checks

Required checks

Repo link: missing from PR body

How to fix: Add the following to your PR description:

Forge link: https://github.com/your-org/your-project

❌ **pkg.go.dev**: missing from PR body
  > **How to fix:** Add the following to your PR description:
  > ```
pkg.go.dev: https://pkg.go.dev/github.com/your-org/your-project

Go Report Card: missing from PR body

How to fix: Add the following to your PR description:

goreportcard.com: https://goreportcard.com/report/github.com/your-org/your-project


### Additional checks

⚠️ **Coverage**: missing from PR body
  > **How to fix:** Add a coverage service link to your PR description:
  > ```
Coverage: https://app.codecov.io/gh/your-org/your-project

Popular options: Codecov, Coveralls. Integrate one with your CI to track coverage automatically.


Action needed: one or more required checks failed. Please update your PR body with the missing links and ensure the repository meets the quality standards.

These checks are automated and do not replace maintainer review. See CONTRIBUTING.md for full guidelines.


PR Diff Validation

Content checks

Files changed: only README.md
Description: ends with punctuation
Description tone: no promotional language detected
Category size: Security has 62 items

Warnings

⚠️ Changes: 1 added + 1 removed (update or move — please confirm in PR description)
⚠️ Link text: acmetool differs from repo name acme

How to fix: The link text should be the exact project name.
If the project name really is acmetool, this is fine. Otherwise change it to: - [acme](https://github.com/hlandau/acme) - ...

Automated diff validation — does not replace maintainer review.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Restore alphabetical order in README Security tools list

🐞 Bug fix 📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Reorder Security section entries to preserve alphabetical sorting.
• Fix CI failure caused by TestAlpha enforcing list ordering.
• Keep change scoped to a single list item move for clean submissions.
High-Level Assessment

The direct reorder is the correct and lowest-risk fix: it restores the documented alphabetical invariant that the test enforces. Alternatives (changing the test or relaxing sorting rules) would increase scope and risk for a simple ordering regression.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
README.mdFix alphabetical ordering in Security tools list +1/-1

Fix alphabetical ordering in Security tools list

• Moves the 'acmetool' entry to appear after 'acme-proxy' so the Security section remains alphabetically sorted. This restores compliance with the repository’s ordering expectations and fixes the associated 'TestAlpha' failure.

README.md

@qodo-code-review

Copy link
Copy Markdown

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@matveynator

Copy link
Copy Markdown
Contributor Author

CI note: Running test passes. Post quality report fails because the workflow treats every README-only maintenance move as a new package submission and requires forge/pkg/report links. This PR adds or changes no package; it only moves the existing acmetool line to repair the pre-existing TestAlpha failure on main and unblock #6590.

@matveynator matveynator mentioned this pull request Aug 16, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant