Skip to content

fix: rename acmetool to acme to match repo name and fix alphabetical order - #6595

Open
morning-verlu wants to merge 1 commit into
avelino:mainfrom
morning-verlu:fix/security-alphabetical
Open

fix: rename acmetool to acme to match repo name and fix alphabetical order#6595
morning-verlu wants to merge 1 commit into
avelino:mainfrom
morning-verlu:fix/security-alphabetical

Conversation

@morning-verlu

Copy link
Copy Markdown

What changed

The link text acmetool does not match the repository name acme (https://github.com/hlandau/acme). Renaming it to acme also fixes the alphabetical ordering in the Security section, as acme sorts before acme-proxy. This resolves the TestAlpha CI failure (see #6550).

Forge link: https://github.com/hlandau/acme
pkg.go.dev: https://pkg.go.dev/github.com/hlandau/acme
goreportcard.com: https://goreportcard.com/report/github.com/hlandau/acme

…order

The link text `acmetool` does not match the repository name `acme`.
Renaming it to `acme` also fixes the alphabetical ordering in the
Security section, as `acme` sorts before `acme-proxy`. Fixes avelino#6550.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix acme name and Security list ordering

🐞 Bug fix 📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Rename acmetool to acme to match the linked repository.
• Restore alphabetical ordering in the Security section and resolve TestAlpha failures.
High-Level Assessment

The direct label correction is optimal: it preserves the existing repository URL and description while aligning the displayed name with the upstream project and alphabetical-list validation.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
README.mdCorrect acme project name in Security section +1/-1

Correct acme project name in Security section

• Renames the displayed 'acmetool' entry to 'acme', matching the linked repository and restoring alphabetical ordering before 'acme-proxy'.

README.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more'

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@github-actions

Copy link
Copy Markdown

Automated Quality Checks

Required checks

Repo: missing go.mod

How to fix: No go.mod file found at the repository root.
Initialize Go modules in your project:

go mod init github.com/your-org/your-project
go mod tidy
git add go.mod go.sum && git commit -m "add go module" && git push

pkg.go.dev: OK
Go Report Card: OK (grade unknown)

Additional checks

⚠️ License: no open source license detected

How to fix: Add a LICENSE file to your repository root.
Choose one at https://choosealicense.com — common choices for Go projects: MIT, Apache-2.0, BSD-3-Clause.
Maturity: repo has 5+ months of history
⚠️ CI/CD: no GitHub Actions workflows found
How to fix: Add a CI workflow to run tests automatically.
Create .github/workflows/test.yml — see https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-go
README: present
⚠️ Coverage: missing from PR body
How to fix: Add a coverage service link to your PR description:

Coverage: https://app.codecov.io/gh/your-org/your-project

Popular options: [Codecov](https://codecov.io), [Coveralls](https://coveralls.io). Integrate one with your CI to track coverage automatically.

---
> **Action needed:** one or more required checks failed. Please update your PR body with the missing links and ensure the repository meets the [quality standards](https://github.com/avelino/awesome-go/blob/main/CONTRIBUTING.md#quality-standards).

_These checks are automated and do not replace maintainer review. See [CONTRIBUTING.md](https://github.com/avelino/awesome-go/blob/main/CONTRIBUTING.md) for full guidelines._

---

## PR Diff Validation

### Content checks

✅ **Files changed**: only README.md
✅ **Link consistency**: README link matches forge link in PR body
✅ **Link text**: matches repository name
✅ **Description**: ends with punctuation
✅ **Description tone**: no promotional language detected
✅ **Category size**: Security has 62 items

### Warnings

⚠️ **Changes**: 1 added + 1 removed (update or move — please confirm in PR description)


_Automated diff validation — does not replace maintainer review._
<!-- Sticky Pull Request Commentpr-quality-check -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant