Add orderbook to Financial - #6611
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Automated Quality ChecksRequired checks✅ Repo: accessible, has go.mod and SemVer release Additional checks✅ License: MIT
Coverage: https://app.codecov.io/gh/your-org/your-project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required links
pkg/...andinternal/..., 73.4% counting thecmd/binaries andexamples/demos.codecov.ymland the upload step are committed; the repo is not activated on codecov.io yet, so I have not put a link here that would 404.Pre-submission checklist
Repository requirements
go.modfile and at least one SemVer release (vX.Y.Z) — v0.26.0gojp/goreportcardis archived. The badge endpoint now serves an SVG reading "go report: retired", so it was dropped from the README rather than left advertising a dead service. The report URL is still in the required-links block above.go test -race, benchmarks, and a nightly soakPull Request content
ofxgoand the existingorderbook, beforepayme)go test main_test.go main.gopasses identically with and without this change — 4 pre-existingTestAlphaordering errors onmain, in Data stores with expiring records (easycache/echovault) and Libraries that are used to help make your application more secure (acme-proxy/acmetool), neither touched here.Category quality
Checked the five nearest entries; all are live and none are archived:
ofxgo(Feb 2026),orderbook— i25959341 (Apr 2025),payme(Jul 2026),paystack-sdk-go(Jun 2026),money— govalues (Jan 2025).About the package
An embeddable limit order book and matching engine. It works in
int64ticks and lots with no floating point on the money path, and a per-symbolInstrumentconverts decimals only at the API boundary.Runnerfronts it with an MPSC queue for concurrent producers.Matchinto a caller-supplied buffer allocates 0 B/op.pkg/walprovides a checksummed write-ahead log with snapshots, segment rotation and retention.Note on the duplicate name: there is already an
orderbookin this section (i25959341/orderbook). They are different projects with the same package name, which the section already accommodates fordecimal(three entries) andgo-finance(two). Happy to rename the link text if you would rather disambiguate.Disclosure: I'm the author of the project. It is explicit that it is an experiment rather than a product — it has never run a live market, and docs/PRODUCTION-READINESS.md is a written account of what it does not do.