Fix commit script internal key handling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

brianorwhatever wants to merge 1 commit into fix-metadata from djei83-codex/clarify-changes-not-as-expected

Contributor

brianorwhatever commented May 21, 2025

Summary

allow P2TRAddressInfo to omit internalKey
leave internalKey undefined when preparing inscriptions without a recovery key
fallback safely when commit script must be derived from taproot output

Testing

bun test packages/ordinalsplus/tests/unit/transactions/reveal-transaction.test.ts (fails: Cannot find module)
npm test (fails: 45 tests failed)


          fix commit address script generation

brianorwhatever added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels