Closed
Conversation
Owner
|
Sorry for the late feedback. We decided to switch to launching JETLS using the Pkg app, which meant we also needed to update the VSCode client implementation and documentation. We've completed that work in this PR. Sorry I couldn't merge this, but thanks for submitting it anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies
runserver.jlinto a new moduleCLIwhich is exposed as an app.I realize that this might be incompatible with some existing workflow to compile with JuliaC, so I realize it may not be sensible to merge this. I have kept
runserver.jlso as not to completely break compatibility.If you feel it makes sense to merge this, I could update the README to reflect it. If not, you can close this and if you feel it's appropriate I can open an issue for this.