Conversation
abap34
commented
Oct 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 70.53% 70.88% +0.34%
==========================================
Files 38 38
Lines 3662 3647 -15
==========================================
+ Hits 2583 2585 +2
+ Misses 1079 1062 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
64d7eee to
2fc4281
Compare
Co-Authored-By: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
2fc4281 to
3667cb2
Compare
aviatesk
reviewed
Oct 23, 2025
Co-Authored-By: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
reviewed
Oct 23, 2025
aviatesk
approved these changes
Oct 23, 2025
Owner
|
Thanks so much for working on this, @abap34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the configuration storage object from a
Dictto a struct (JETLSConfig).This enables:
Implementation Details
A new dependency, Configurations.jl, has been introduced.
This package maps TOML-parsed
Dicts to structs.It’s relatively lightweight, so adding it as a dependency should not be a significant issue.
Since Configurations.jl does not currently provide full key paths for nested
KeyErrors,the helper function
collect_unmatched_keyfrom the previous implementation remains temporarily for error reporting.I plan to submit a PR to Configurations.jl to support this feature, so that, this workaround can be removed.
Schema Generation
With JSONSchemaGenerator.jl,
a JSON Schema can be generated simply as follows:
Using this approach, completion and type checking become available in various editors.
(The example below uses VSCode with even-better-toml.)
In the long term, it would be convenient to have the schema generated in CI at release time and registered to schemastore.org. This part is not critical for the LS itself, so we can be more liberal in using convenient tools and dependencies to improve the workflow.
I would be happy to discuss this further later on :)