Conversation
aviatesk
force-pushed
the
avi/jlfmt
branch
2 times, most recently
from
5fac5d0 to
eed69d9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 69.47% 68.73% -0.74%
==========================================
Files 39 39
Lines 3685 3723 +38
==========================================
- Hits 2560 2559 -1
- Misses 1125 1164 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abap34
force-pushed
the
abap34/config-schema
branch
from
2fc4281 to
3667cb2
Compare
abap34
reviewed
Oct 23, 2025
abap34
reviewed
Oct 23, 2025
aviatesk
force-pushed
the
avi/jlfmt
branch
2 times, most recently
from
0029580 to
9292668
Compare
aviatesk
force-pushed
the
avi/workspace/configuration
branch
from
4804031 to
fe2a63d
Compare
aviatesk
force-pushed
the
avi/workspace/configuration
branch
from
fe2a63d to
bff164c
Compare
aviatesk
force-pushed
the
avi/jlfmt
branch
2 times, most recently
from
5404191 to
66ea7ea
Compare
aviatesk
force-pushed
the
avi/jlfmt
branch
2 times, most recently
from
773a855 to
96ba7b1
Compare
This commit extends the formatting system to support multiple formatter
backends beyond Runic.jl. Users can now choose between preset formatters
("Runic" or "JuliaFormatter") or configure custom formatters with their
own executables.
The formatter configuration has been redesigned from a nested structure
(`formatter.runic.executable`) to a simpler top-level `formatter`
setting that accepts either:
- A preset name string: "Runic" or "JuliaFormatter"
- A custom formatter defined under `formatter.custom` with `executable`
and optional `executable_range` fields
The preset names use proper package names for clarity, while executables
remain as `runic`/`jlfmt` to match the actual binary names.
Due to limitations in Configurations.jl, custom formatters must be
specified in the `[formatter.custom]` section rather than directly as
the `formatter` value. Custom formatters can specify separate
executables for document and range formatting operations.
Additionally, `FormattingOptions` from LSP requests are now propagated
through the formatting pipeline, enabling formatters to respect
client-provided settings like tab size. For JuliaFormatter, the tab size
option is passed via the `--indent` flag. This client-wise setting will
be overwritten by .JuliaFormatter.toml configuration if it's found since
we are using the `--prioritize-config-file` option.
Requires domluna/JuliaFormatter.jl#947 to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the formatting system to support multiple formatter backends beyond Runic.jl. Users can now choose between preset formatters (
"runic"or"jlfmt") or configure custom formatters with their own executables.The formatter configuration has been redesigned from a nested structure (
formatter.runic.executable) to a simpler top-levelformattersetting that accepts either:"runic"or"jlfmt"formatter.customwithexecutableand optionalexecutable_rangefieldsDue to limitations in Configurations.jl, custom formatters must be specified in the
[formatter.custom]section rather than directly as theformattervalue. Custom formatters can specify separate executables for document and range formatting operations.Additionally,
FormattingOptionsfrom LSP requests are now propagated through the formatting pipeline, enabling formatters to respect client-provided settings like tab size. For JuliaFormatter, the tab size option is passed via the--indentflag. This client-wise setting will be overwritten by .JuliaFormatter.toml configuration if it's found since we are using the--prioritize-config-fileoption.Requires domluna/JuliaFormatter.jl#947 to be merged.