JSONRPC.jl: move implementation to LSP.jl internal scope#303
Merged
aviatesk merged 1 commit intoavi/JSON-v1-againfrom Nov 19, 2025
Merged
JSONRPC.jl: move implementation to LSP.jl internal scope#303aviatesk merged 1 commit intoavi/JSON-v1-againfrom
aviatesk merged 1 commit intoavi/JSON-v1-againfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## avi/JSON-v1-again #303 +/- ##
=====================================================
- Coverage 66.28% 66.27% -0.01%
=====================================================
Files 39 39
Lines 4096 4095 -1
=====================================================
- Hits 2715 2714 -1
Misses 1381 1381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2322b8b to
af6145d
Compare
a8f5095 to
321ec03
Compare
af6145d to
a718c6c
Compare
The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.
321ec03 to
9b6b0ea
Compare
aviatesk
added a commit
that referenced
this pull request
Nov 19, 2025
The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.
aviatesk
added a commit
that referenced
this pull request
Nov 19, 2025
The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.