Skip to content

JSONRPC.jl: move implementation to LSP.jl internal scope#303

Merged
aviatesk merged 1 commit intoavi/JSON-v1-againfrom
avi/move-JSONRPC-to-LSP
Nov 19, 2025
Merged

JSONRPC.jl: move implementation to LSP.jl internal scope#303
aviatesk merged 1 commit intoavi/JSON-v1-againfrom
avi/move-JSONRPC-to-LSP

Conversation

@aviatesk
Copy link
Copy Markdown
Owner

The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.27%. Comparing base (a718c6c) to head (9b6b0ea).
⚠️ Report is 1 commits behind head on avi/JSON-v1-again.

Files with missing lines Patch % Lines
src/testrunner/testrunner.jl 0.00% 2 Missing ⚠️
src/JETLS.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           avi/JSON-v1-again     #303      +/-   ##
=====================================================
- Coverage              66.28%   66.27%   -0.01%     
=====================================================
  Files                     39       39              
  Lines                   4096     4095       -1     
=====================================================
- Hits                    2715     2714       -1     
  Misses                  1381     1381              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The current implementation of JSONRPC.jl is actually LSP-dependent and
does not suit the generic name "JSONRPC". Therefore, it would be better
to keep that implementation internal to LSP.jl.
@aviatesk aviatesk force-pushed the avi/move-JSONRPC-to-LSP branch from 321ec03 to 9b6b0ea Compare November 19, 2025 10:16
@aviatesk aviatesk merged commit cfff126 into avi/JSON-v1-again Nov 19, 2025
10 of 13 checks passed
@aviatesk aviatesk deleted the avi/move-JSONRPC-to-LSP branch November 19, 2025 10:44
aviatesk added a commit that referenced this pull request Nov 19, 2025
The current implementation of JSONRPC.jl is actually LSP-dependent and
does not suit the generic name "JSONRPC". Therefore, it would be better
to keep that implementation internal to LSP.jl.
aviatesk added a commit that referenced this pull request Nov 19, 2025
The current implementation of JSONRPC.jl is actually LSP-dependent and
does not suit the generic name "JSONRPC". Therefore, it would be better
to keep that implementation internal to LSP.jl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant