LSP: a bunch of code cleanups/refactoring#309
Merged
Conversation
aviatesk
force-pushed
the
avi/LSP-refactor
branch
from
045a608 to
6819515
Compare
The current implementation of JSONRPC.jl is actually LSP-dependent and does not suit the generic name "JSONRPC". Therefore, it would be better to keep that implementation internal to LSP.jl.
aviatesk
force-pushed
the
avi/LSP-refactor
branch
from
6819515 to
53cab2a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 69.24% 69.23% -0.01%
==========================================
Files 39 39
Lines 3882 3881 -1
==========================================
- Hits 2688 2687 -1
Misses 1194 1194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of additional goodies, separated from #301 for easier migration.