pkg: Add activate_with_early_release for early lock release#348
Merged
pkg: Add activate_with_early_release for early lock release#348
Conversation
aviatesk
force-pushed
the
avi/early-release-activation-lock
branch
from
425882a to
bb579fe
Compare
Add a variant of activate_do that allows early release of ACTIVATE_LOCK before the callback completes. The caller can notify the passed event to signal that the activated environment is no longer needed, enabling the environment to be restored and the lock released while the callback continues executing. Use this in full-analysis to release the activation lock after the code loading phase finishes, allowing other analysis requests to proceed while type inference continues in the background.
aviatesk
force-pushed
the
avi/early-release-activation-lock
branch
from
bb579fe to
b625684
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 65.62% 65.78% +0.15%
==========================================
Files 40 40
Lines 4154 4173 +19
==========================================
+ Hits 2726 2745 +19
Misses 1428 1428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a variant of activate_do that allows early release of ACTIVATE_LOCK before the callback completes. The caller can notify the passed event to signal that the activated environment is no longer needed, enabling the environment to be restored and the lock released while the callback continues executing.
Use this in full-analysis to release the activation lock after the code loading phase finishes, allowing other analysis requests to proceed while type inference continues in the background.