config: Restrict .JETLSConfig.toml to workspace root only#356
Merged
config: Restrict .JETLSConfig.toml to workspace root only#356
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 64.82% 64.82%
=======================================
Files 42 42
Lines 4281 4281
=======================================
Hits 2775 2775
Misses 1506 1506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviatesk
force-pushed
the
avi/memory-footprint
branch
from
a13f483 to
b93070a
Compare
aviatesk
force-pushed
the
avi/fix-root-config
branch
from
4e46f13 to
0f3d5e8
Compare
Use RelativePattern for file watching to ensure .JETLSConfig.toml is only recognized in the workspace root directory. Previously, config files in subdirectories were also loaded due to the "**/" glob pattern, which was inconsistent with the documentation.
aviatesk
force-pushed
the
avi/fix-root-config
branch
from
0f3d5e8 to
520ff0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use RelativePattern for file watching to ensure .JETLSConfig.toml is only recognized in the workspace root directory. Previously, config files in subdirectories were also loaded due to the "**/" glob pattern, which was inconsistent with the documentation.