Fix and simplify jetls spawning logic for Windows#375
Merged
aviatesk merged 1 commit intoaviatesk:masterfrom Dec 9, 2025
Merged
Fix and simplify jetls spawning logic for Windows#375aviatesk merged 1 commit intoaviatesk:masterfrom
aviatesk merged 1 commit intoaviatesk:masterfrom
Conversation
Fixes aviatesk#339, since aviatesk#372 was not sufficient.
aviatesk
approved these changes
Dec 9, 2025
Owner
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
LGTM. Using jetls always seems much reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339, since #372 was not sufficient.
#372 was an improvement and the
shell=truewas needed. There was still a flaw in the name of the executable.Normally
jetlswill bejetls.bat, but it can still be spawned withjetls, as long as it getsshell=true. That allows us to simplify the logic, fixing #372 in the process. The problem was that the default value ofjetlswas used, and since that didn't end with.bat, it did not getshell=true. I think we can just always use the shell on Windows, since folks will have a.batin practice, and the code is simpler.