diagnostic: Report method overwrite warning#417
Merged
Conversation
Add `toplevel/method-overwrite` diagnostic that warns when a method with the same signature is defined multiple times within a package. The diagnostic message shows the method signature and module name, with a link to navigate to the first definition location.
aviatesk
force-pushed
the
avi/diagnostic-report-duplicated-method-def
branch
from
8aa56fd to
620e27b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 61.90% 64.31% +2.41%
==========================================
Files 56 44 -12
Lines 5638 5338 -300
==========================================
- Hits 3490 3433 -57
+ Misses 2148 1905 -243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviatesk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
toplevel/method-overwritediagnostic that warns when a method with the same signature is defined multiple times within a package.The diagnostic message shows the method signature and module name, with a link to navigate to the first definition location.
Closes #387