diagnostic: Report abstract field type information#418
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 64.31% 64.54% +0.22%
==========================================
Files 44 44
Lines 5338 5378 +40
==========================================
+ Hits 3433 3471 +38
- Misses 1905 1907 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a new `Information` level diagnostic (`toplevel/abstract-field`)
that reports when a struct field has an abstract type. This helps catch
potential performance issues caused by type instability.
The detection works by hooking into `JuliaInterpreter.step_expr!` and
checking for `Core._typebody!` calls. When a struct is being defined,
the field types are inspected using the new `is_abstract_fieldtype`
helper function.
Currently detects cases like `Vector{Integer}` and `AbstractVector{Int}`
but does not yet handle `UnionAll` types like `Vector{<:Integer}`.
aviatesk
force-pushed
the
avi/diagnostic-report-abstract-field
branch
from
3a016f6 to
962f810
Compare
aviatesk
changed the title
aviatesk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
Informationlevel diagnostic (toplevel/abstract-field) that reports when a struct field has an abstract type. This helps catch potential performance issues caused by type instability.The detection works by hooking into
JuliaInterpreter.step_expr!and checking forCore._typebody!calls. When a struct is being defined, the field types are inspected using the newis_abstract_fieldtypehelper function.Currently detects cases like
Vector{Integer}andAbstractVector{Int}but does not yet handleUnionAlltypes likeVector{<:Integer}.