Conversation
Moved the 2025-12-19 entry below the announcement section to improve document flow and readability.
Add `commit` skill for Claude Code integration: - Defines project-specific commit message format (component prefix, 72 char limit, GitHub references) - References CLAUDE.md for Git safety rules Add "Git operations" section to AGENTS.md with safety rules: - Require explicit user permission for Git operations - Never auto-amend or auto-fixup on feedback Update `.gitignore` to track `.claude/skills/` while ignoring other Claude Code temporary files. Improve test execution documentation with clearer instructions for running component-specific tests with proper project flags.
Add a new configuration option `diagnostic.allow_unused_underscore` (default: `true`) that suppresses unused variable diagnostics for names starting with `_`. This follows the common convention in many programming languages where underscore-prefixed names indicate intentionally unused variables. When enabled, `lowering/unused-argument` and `lowering/unused-local` diagnostics are not reported for variables like `_x`, `__unused`, or just `_`. Written by Claude Co-authored-by: Claude <noreply@anthropic.com>
When `diagnostic.allow_unused_underscore` is `false`, the code action now replaces the entire variable name with `_` instead of being disabled. This provides a useful action in both configurations: - `allow_unused_underscore=true`: "Prefix with '_'" (e.g., `x` → `_x`) - `allow_unused_underscore=false`: "Replace with '_'" (e.g., `x` → `_`) Written by Claude Co-Authored-By: Claude <noreply@anthropic.com>
Add `toplevel/method-overwrite` diagnostic that warns when a method with the same signature is defined multiple times within a package. The diagnostic message shows the method signature and module name, with a link to navigate to the first definition location.
Add a new `Information` level diagnostic (`toplevel/abstract-field`)
that reports when a struct field has an abstract type. This helps catch
potential performance issues caused by type instability.
The detection works by hooking into `JuliaInterpreter.step_expr!` and
checking for `Core._typebody!` calls. When a struct is being defined,
the field types are inspected using the new `is_abstract_fieldtype`
helper function.
Currently detects cases like `Vector{Integer}` and `AbstractVector{Int}`
but does not yet handle `UnionAll` types like `Vector{<:Integer}`.
Previously, `AbstractFieldReport` used the line where `Core._typebody!` was called, which didn't accurately reflect the field definition location. This change extracts the actual field definition node from the AST by: - Adding `current_node` field to `LSInterpreter` to track the current `SyntaxNode` being lowered - Overloading `JET.lower_with_err_handling` to capture the node - Implementing `try_extract_field_line` to find field definitions within struct declarations Also adds `encoding` field to `SavedFileInfo` and extends `jsobj_to_range` and `offset_to_xy` to work with `SavedFileInfo`, enabling proper range calculation from `SyntaxNode`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR releases version
2025-12-31.Checklist
release / Test JETLS.jl with release environmentrelease / Test jetls executable with release environmentPost-merge
releases/2025-12-31branch can be deleted after merging