Conversation
The `update-changelog` job needs `actions: write` permission to trigger `gh workflow run release.yml --ref release` for the documentation build after updating the CHANGELOG on master.
Remove the `push` trigger from `release.yml` since the release branch requires PRs before merging. Update the test job conditions to explicitly check for `pull_request` events, preventing redundant test runs after merge.
Updates JET dependency to revision 8fe5f1b and refactors method overwrite detection to handle both `Core.CodeInfo` and `Expr` source types. Moves `get_lines_in_src` to `full-analysis.jl` and adds new `get_lines_in_ex` function, making the analysis more robust across different source representations.
Move `_try_extract_field_line` from `Interpreter.jl` to `ast.jl` as `try_extract_field_line`, making it a reusable utility for extracting field line information from struct definitions. Bug fixes: - Handle `<:` subtyping syntax (`struct A <: B`) - Handle `const` field modifiers (`const x::Int`) Test coverage expanded to verify these new cases and check actual `sourcetext` of returned nodes.
analysis: Update JET dependency and fix method overwrite detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR releases version
2026-01-01.Checklist
release / Test JETLS.jl with release environmentrelease / Test jetls executable with release environmentPost-merge
releases/2026-01-01branch can be deleted after merging