completion: Add strip_prefix config for LaTeX/emoji completions#445
Merged
completion: Add strip_prefix config for LaTeX/emoji completions#445
strip_prefix config for LaTeX/emoji completions#445Conversation
Some editors (e.g., Zed) don't properly use the LSP `sortText` field for completion items containing special characters like `\`, falling back to `label`-based sorting. This causes incorrect completion order. This change adds a new configuration option `completion.latex_emoji.strip_prefix` that controls whether to strip `\` or `:` prefixes from completion labels. When set to `missing` (default), JETLS auto-detects based on the client name. The auto-detection currently only covers a limited set of known clients, so users experiencing sorting issues can explicitly set this option.
By changing `!=` to `!==` in `ConfigChangeTracker` to use identity comparison.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 65.42% 65.46% +0.03%
==========================================
Files 44 44
Lines 5678 5681 +3
==========================================
+ Hits 3715 3719 +4
+ Misses 1963 1962 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some editors (e.g., Zed) don't properly use the LSP
sortTextfield for completion items containing special characters like\, falling back tolabel-based sorting. This causes incorrect completion order.This change adds a new configuration option
completion.latex_emoji.strip_prefixthat controls whether to strip
\or:prefixes from completion labels.When set to
missing(default), JETLS auto-detects based on the client name.The auto-detection currently only covers a limited set of known clients, so users experiencing sorting issues can explicitly set this option.