diagnostic: Add lowering/undef-global-var for on-change feedback#450
Merged
diagnostic: Add lowering/undef-global-var for on-change feedback#450
lowering/undef-global-var for on-change feedback#450Conversation
Add a new `lowering/undef-global-var` diagnostic that reports undefined global variable references on document change. This provides faster feedback compared to `inference/undef-global-var`, which runs on save. The on-change diagnostic uses JuliaLowering's variable analysis to detect simple undefined references with accurate position information (exact character range). The on-save version detects a superset of cases including qualified references like `Base.undefvar`, but reports position on a line basis.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 65.53% 65.63% +0.10%
==========================================
Files 44 44
Lines 5724 5742 +18
==========================================
+ Hits 3751 3769 +18
Misses 1973 1973
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-01-06.at.19.12.37.mov
Add a new
lowering/undef-global-vardiagnostic that reports undefined global variable references on document change. This provides faster feedback compared toinference/undef-global-var, which runs on save.The on-change diagnostic uses JuliaLowering's variable analysis to detect simple undefined references with accurate position information (exact character range). The on-save version detects a superset of cases including qualified references like
Base.undefvar, but reports position on a line basis.