document-symbol: Cache symbols for unsynced files#484
Merged
Conversation
Enable document symbol caching for files not currently open in the editor (unsynced files with `version == 0`). Previously, only synced files used the cache, causing repeated parsing for workspace symbol searches.
Change `DocumentSymbolCache` from `SWContainer` to `LWContainer` to ensure thread-safe concurrent writes. Since message handlers run concurrently, the cache can be written to from multiple sources simultaneously: - `textDocument/didChange` invalidates cache for synced files - `workspace/didChangeWatchedFiles` invalidates cache for unsynced files - `get_document_symbols!` writes on cache miss `SWContainer` does not protect against concurrent writes, so updates could be lost. `LWContainer` uses lock-serialized writes to ensure correctness.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 67.37% 67.38% +0.01%
==========================================
Files 46 46
Lines 6528 6531 +3
==========================================
+ Hits 4398 4401 +3
Misses 2130 2130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable document symbol caching for files not currently open in the editor (unsynced files with
version == 0). Previously, only synced files used the cache, causing repeated parsing for workspace symbol searches.Also changes
DocumentSymbolCachefromSWContainertoLWContainerto ensure thread-safe concurrent writes. Since message handlers run concurrently, the cache can be written to from multiple sources simultaneously:textDocument/didChangeinvalidates cache for synced filesworkspace/didChangeWatchedFilesinvalidates cache for unsynced filesget_document_symbols!writes on cache missSWContainerdoes not protect against concurrent writes, so updates could be lost.LWContaineruses lock-serialized writes to ensure correctness.