definition: Support global binding definitions#487
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 67.51% 67.67% +0.16%
==========================================
Files 46 46
Lines 6544 6574 +30
==========================================
+ Hits 4418 4449 +31
+ Misses 2126 2125 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add `find_global_binding_definitions` to find definition sites for global bindings across the package using binding occurrence analysis. Previously, go-to-definition for global variables couldn't find their definition sites since runtime reflection doesn't provide binding location information. The implementation benefits from the binding occurrences cache, avoiding redundant lowering for consecutive definition requests. Also refactors `handle_DefinitionRequest` to call `_select_target_binding` once and reuse the result for both local and global binding paths.
aviatesk
force-pushed
the
avi/global-binding-definition
branch
from
6317b08 to
3b703e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
find_global_binding_definitionsto find definition sites for global bindings across the package using binding occurrence analysis. Previously, go-to-definition for global variables couldn't find their definition sites since runtime reflection doesn't provide binding location information.The implementation benefits from the binding occurrences cache, avoiding redundant lowering for consecutive definition requests.
Also refactors
handle_DefinitionRequestto call_select_target_bindingonce and reuse the result for both local and global binding paths.