Skip to content

fix signature help fail with invalid arg#582

Merged
aviatesk merged 1 commit intomasterfrom
abap34/sighelp-nonident
Mar 8, 2026
Merged

fix signature help fail with invalid arg#582
aviatesk merged 1 commit intomasterfrom
abap34/sighelp-nonident

Conversation

@abap34
Copy link
Collaborator

@abap34 abap34 commented Mar 8, 2026

I noticed that the language server throws an exception when the following typo occurs:

f(x; y = 1) = x + y
f(0; y.y=1│)

This appears to be syntactically valid (it fails during lowering), but signature-help seems to attempt to analyze it and fails. I added an additional check to handle this case.

@abap34 abap34 force-pushed the abap34/sighelp-nonident branch from 994524f to b6b1d7a Compare March 8, 2026 18:01
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.72%. Comparing base (0a310ca) to head (b6b1d7a).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   67.68%   67.72%   +0.04%     
==========================================
  Files          51       51              
  Lines        8309     8311       +2     
==========================================
+ Hits         5624     5629       +5     
+ Misses       2685     2682       -3     
Flag Coverage Δ
JETLS.jl 67.72% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aviatesk aviatesk merged commit 018aa0b into master Mar 8, 2026
16 of 17 checks passed
@aviatesk aviatesk deleted the abap34/sighelp-nonident branch March 8, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants