Conversation
Use the `name_val` attribute directly to retrieve identifier names inside `K"inert"` nodes, instead of going through `sourcetext`. This avoids a crash when `SyntaxTree` nodes have `LineNumberNode` provenance (which occurs for nodes created via `expr_to_est` during old-style macro expansion), since `sourcetext` would fail with `MethodError` on such nodes. Also simplify the `foreach_inert_identifier` / `foreach_identifier_in_inert` helpers by removing the unnecessary `_`-prefixed indirection. Fixes #583
name_val instead of sourcetextname_val instead of sourcetext
name_val instead of sourcetextname_val instead of JS.sourcetext
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 67.72% 67.74% +0.01%
==========================================
Files 51 51
Lines 8311 8315 +4
==========================================
+ Hits 5629 5633 +4
Misses 2682 2682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
name_valattribute directly to retrieve identifier names insideK"inert"nodes, instead of going throughsourcetext. This avoids a crash whenSyntaxTreenodes haveLineNumberNodeprovenance (which occurs for nodes created viaexpr_to_estduring old-style macro expansion), sincesourcetextwould fail withMethodErroron such nodes.Also simplify the
foreach_inert_identifier/foreach_identifier_in_inerthelpers by removing the unnecessary_-prefixed indirection.Fixes #583