Conversation
`K"doc"` nodes are converted to `Core.@doc` macrocalls by `preprocessed_green_children` during `SyntaxTree` construction, so they never appear in the final tree. Remove the unreachable `K"doc"` branches from `iterate_toplevel_tree` and `extract_toplevel_symbol!`, along with the unused `extract_doc_symbol!` function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 67.71% 67.88% +0.17%
==========================================
Files 51 51
Lines 8307 8295 -12
==========================================
+ Hits 5625 5631 +6
+ Misses 2682 2664 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K"doc"nodes are converted toCore.@docmacrocalls bypreprocessed_green_childrenduringSyntaxTreeconstruction, so they never appear in the final tree. Remove the unreachableK"doc"branches fromiterate_toplevel_treeandextract_toplevel_symbol!, along with the unusedextract_doc_symbol!function.Closes #586.