Skip to content

Remove dead K"doc" handling code#589

Merged
aviatesk merged 1 commit intomasterfrom
avi/586
Mar 11, 2026
Merged

Remove dead K"doc" handling code#589
aviatesk merged 1 commit intomasterfrom
avi/586

Conversation

@aviatesk
Copy link
Owner

K"doc" nodes are converted to Core.@doc macrocalls by preprocessed_green_children during SyntaxTree construction, so they never appear in the final tree. Remove the unreachable K"doc" branches from iterate_toplevel_tree and extract_toplevel_symbol!, along with the unused
extract_doc_symbol! function.

Closes #586.

`K"doc"` nodes are converted to `Core.@doc` macrocalls by
`preprocessed_green_children` during `SyntaxTree` construction,
so they never appear in the final tree. Remove the unreachable
`K"doc"` branches from `iterate_toplevel_tree` and
`extract_toplevel_symbol!`, along with the unused
`extract_doc_symbol!` function.
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.88%. Comparing base (d0e1261) to head (269bdd2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   67.71%   67.88%   +0.17%     
==========================================
  Files          51       51              
  Lines        8307     8295      -12     
==========================================
+ Hits         5625     5631       +6     
+ Misses       2682     2664      -18     
Flag Coverage Δ
JETLS.jl 67.88% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aviatesk aviatesk merged commit 3926200 into master Mar 11, 2026
18 of 19 checks passed
@aviatesk aviatesk deleted the avi/586 branch March 11, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive Unused import @setup_workload

1 participant