-
Notifications
You must be signed in to change notification settings - Fork 0
Support multiple JsonSerializerContext classes for polymorphic types #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for generating polymorphic JSON converters when multiple
JsonSerializerContextclasses reference the same polymorphic types. The generator now properly merges configurations across multiple contexts and generates converters for each namespace.Key Changes
Core Functionality
JsonSerializerContextclasses that reference the same polymorphic typesPolymorphicJsonSerializerContextConfigurationMergerto merge configurations from multiple contextsPolymorphicJsonSerializerMetadatato separate metadata concerns from configurationCode Quality Improvements
Testing Enhancements
MultipleContextsWorksvalidates generation with multipleJsonSerializerContextclassesMySecondJsonSerializerContextand nullable leaf contracts with custom delimitersTechnical Details
ISymbol) to multiple contexts (EquatableArray<ISymbol>)JsonSerializerContextNET_10_OR_GREATERconditional compilationTesting
All existing tests pass. New tests added:
JsonPolymorphicConverterGeneratorSnapshotTests.MultipleContextsWorksBaseContractWithCustomDelimiterSerializationTestswith multiple contextsBreaking Changes
None - this is backward compatible. Existing single-context scenarios continue to work as before.