Skip to content

fix(ui): fixed-size scrollable approval card + geometry gate observes card shell#11

Merged
cyhhao merged 2 commits into
mainfrom
fix/approval-card-layout
Jul 10, 2026
Merged

fix(ui): fixed-size scrollable approval card + geometry gate observes card shell#11
cyhhao merged 2 commits into
mainfrom
fix/approval-card-layout

Conversation

@cyhhao

@cyhhao cyhhao commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render approval context as structured detail rows inside a fixed card shell
  • keep the header and action footer fixed while long details and commands scroll in the middle
  • observe the fixed card shell in the visibility guard so content scrolling cannot create a false failure

Verification

  • npm test (80 tests)
  • npm run build
  • git diff --check origin/main...HEAD
  • long multi-line command regression confirms the command remains contained and the action footer stays outside the scroll region
  • geometry regressions confirm the fixed shell passes at the supported minimum size while hidden and parent-occluded surfaces still fail closed

Scope

This changes the sandbox approval surface used by signed reveal, sign, and agent-deliver confirmations. Existing visibility thresholds and parent-frame security checks are unchanged; only the observed interactive target moves from the approve button to the fixed card shell.

Full parent plus sandbox browser regression remains with the orchestrator after merge and redeploy.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vault-sandbox Ready Ready Preview, Comment Jul 10, 2026 6:13am

Request Review

@cyhhao

cyhhao commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d9b067f70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/operationUi.ts Outdated
Comment thread src/style.css Outdated
Comment thread src/style.css Outdated
@cyhhao

cyhhao commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a660529fd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cyhhao
cyhhao merged commit 472f923 into main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant