Skip to content

fix(confirm): allow embedded approval to gain focus#14

Merged
cyhhao merged 1 commit into
mainfrom
fix/approval-focus-preflight
Jul 13, 2026
Merged

fix(confirm): allow embedded approval to gain focus#14
cyhhao merged 1 commit into
mainfrom
fix/approval-focus-preflight

Conversation

@cyhhao

@cyhhao cyhhao commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • let a fully visible embedded approval card become interactive before its iframe has focus
  • keep the focus check in the synchronous approval-click guard immediately before WebAuthn starts
  • cover the mobile lifecycle where the iframe gains focus only after the user taps inside it

Evidence

  • Unit: npm test (84 tests)
  • Contract: confirmation-surface tests cover unfocused readiness, click-time focus rejection, and focused click acceptance
  • Scenario: locked mobile approval can show and enable its action before iframe focus, while Passkey still requires a focused click
  • Build: npm run build
  • Residual manual check: repeat the protected Vault approval on the deployed regression origin after merge

Security Notes

  • visibility, size, intersection, and pending-UI checks still gate button readiness
  • document focus and the live surface sample are synchronously revalidated in the user click before WebAuthn

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vault-sandbox Ready Ready Preview, Comment Jul 13, 2026 10:51am

Request Review

@cyhhao

cyhhao commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8af4f09920

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cyhhao
cyhhao merged commit caa451d into main Jul 13, 2026
3 checks passed
@cyhhao
cyhhao deleted the fix/approval-focus-preflight branch July 13, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant