feature: theming & dark mode #2491
Conversation
|
Code Climate has analyzed commit 9328a24 and detected 0 issues on this pull request. View more on Code Climate. |
|
We might need to wait for Tailwind 4.0 https://twitter.com/adamwathan/status/1758675712800632939?s=46&t=ege6xLvdTHIw1FfCSPTesg |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| module Avo | ||
| class ThemeOptionsController < ApplicationController | ||
| def update | ||
| puts 'updating'.inspect |
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| // 4: 2, | ||
| } | ||
| const value = paddingYScale[this.density] | ||
| console.log(this.density, value) |
There was a problem hiding this comment.
Unexpected console statement.
| } | ||
|
|
||
| updateDOM() { | ||
| console.log(this.template) |
There was a problem hiding this comment.
Unexpected console statement.
| } | ||
|
|
||
| async save() { | ||
| console.log('save') |
There was a problem hiding this comment.
Unexpected console statement.
| }, | ||
| }) | ||
| const data = await response.json() | ||
| console.log(data) |
There was a problem hiding this comment.
Unexpected console statement.
|
This PR has been marked as stale because there was no activity for the past 15 days. |
|
I am quite excited for the new "all CSS variables" Tailwind approach. |
|
Closing for now. Will reopen with Tailwind 4 |
|
Tailwind v4 has landed! 🥳 |
|
Yeah. Big day! I used Tailwind 4 in a separate project and that was pretty easy. We're also pondering a new re-design. Bring it more into this century 😛 |
Description
Closes #631
Closes #1191
Checklist:
Screenshots & recording
CleanShot.2024-02-16.at.23.17.09.mp4
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.