Skip to content

Add pretty_generated option for code fields #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add pretty_generated option for code fields #3782

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75354a6
Add pretty_generated option for code fields
zhephyn Apr 8, 2025
f5d5baa
Fix Linting Errors
zhephyn Apr 9, 2025
2a01109
Fix Trailing WhiteSpace Lint Error
zhephyn Apr 9, 2025
7c270fd
Refactor to remove lambda and add tests
zhephyn Apr 14, 2025
a9e5c36
Fix Linter issues
zhephyn Apr 14, 2025
abb7924
quick fix
Paul-Bob Apr 14, 2025
7756cb8
lint
Paul-Bob Apr 14, 2025
bd4630f
Merge branch 'main' into add_pretty_generated_option_for_code_fields
Paul-Bob Apr 14, 2025
652f419
lint
Paul-Bob Apr 14, 2025
27413d1
Merge branch 'add_pretty_generated_option_for_code_fields' of github.…
Paul-Bob Apr 14, 2025
1e2f90b
lint
Paul-Bob Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/avo/fields/base_field.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ def initialize(id, **args, &block)
@for_attribute = args[:for_attribute]
@meta = args[:meta]
@copyable = args[:copyable] || false
@pretty_generated = args[:pretty_generated] || false

@args = args

Expand Down
10 changes: 10 additions & 0 deletions lib/avo/fields/code_field.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ class CodeField < BaseField
def initialize(id, **args, &block)
hide_on :index

if args[:pretty_generated]
args[:format_using] ||= lambda do
JSON.pretty_generate(JSON.parse(value.to_json))
end

args[:update_using] ||= lambda do
JSON.parse(value)
end
end

super(id, **args, &block)

@language = args[:language].present? ? args[:language].to_s : "javascript"
Expand Down
Loading