Micro performance optimisations #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the array allocation.
This maintains a consistent object shape.
joeldrapper
commented
Feb 15, 2025
Comment on lines
-49
to
+60
| if (candidate.keys - [:class, :slot]).all? { |key| criteria[key] == candidate[key] } | ||
| result << candidate[:class] | ||
| match = false | ||
|
|
||
| candidate.each_key do |key| | ||
| next if key == :class || key == :slot | ||
| match = criteria[key] == candidate[key] | ||
| break unless match | ||
| end | ||
|
|
||
| result << candidate[:class] if match |
There was a problem hiding this comment.
This is the most impactful change. I think this is hit quite a lot when rendering. Using each_key means we can avoid allocating an array of the keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was nerd-sniped when I spotted
bench.rbin the repo and I made a few changes. I think the behaviour is the same as before. At least all the original tests still pass.I had to fix the benchmark script, which I think was using an older API. I also made it executable so you can run it with
bundle exec ./bench.rband I made it enable YJIT.Each optimisation is in its own commit. The overall improvement is about 13%.
rendering only defaultswas683.473know774.274kIPSrendering with overrideswas628.236know712.929kIPS