Removing the redundant ifup command usage - #3297
Conversation
ifup and ifdown commands are deprecated in SLES16 and RHEL releases There are avocado utils network bring up functions already being called to bringup the host intefaces which are sufficient Signed-off-by: Pavaman Subramaniyam <pavsubra@linux.vnet.ibm.com>
|
Attaching the execution result logs with ifup commands removed from the scripts: avocado run --max-parallel-tasks=1 rping.py -m rping.py.data/rping_roce.yaml |
|
Complete result logs are attached to the corresponding Jira task. |
| except Exception: | ||
| self.networkinterface.save(self.ipaddr, self.netmask) | ||
| self.networkinterface.bring_up() | ||
| process.system("ifup %s" % self.iface) |
There was a problem hiding this comment.
@PavamanSubramaniyam can we add the bring_up validation also here?
we are just running ip link set {self.name} up but not validating this, whether the interface is up or not after running this command.
so can you add one more line here
if not self.networkinterface.is_link_up()
self.fail("failed to brin_up the interface after <some-operation>")
this validations are needed across all network tests, but please add this for these file as of now,
in both case, after bring_down and bring_up of interface.
2 participants
ifup and ifdown commands are deprecated in SLES16 and RHEL releases There are avocado utils network bring up functions already being called to bringup the host intefaces which are sufficient