Failed kill debug #148
Closed
Failed kill debug #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case aexpect_helper kill fails we end-up waiting for infinity (eg. when in system call or unschedulable state). Let's change this to up-to-60s wait and then proceeding with warning, which might result in left-behind aexpect_helper but should proceed with other testing. Signed-off-by: Lukáš Doktor <[email protected]>
The POSIX lockf doesn't protect other threads accessing the lock while BSD lock does. Let's switch to BSD locks to protect against multiple threads accessing the same sections. Signed-off-by: Lukáš Doktor <[email protected]>
The Spawn.close() contains critical section that should not be accessed multiple times, which might happen when a user uses aexpect from different threads/processes. Let's add a lock to protect it. Signed-off-by: Lukáš Doktor <[email protected]>
Signed-off-by: Lukáš Doktor <[email protected]>
Merged
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| lock = None | ||
| try: | ||
| try: | ||
| lock = get_lock_fd(self._close_lockfile, timeout=60) |
Check warning
Code scanning / CodeQL
File is not always closed Warning
| :return: True on success, False on failure/timeout | ||
| """ | ||
| try: | ||
| lock_fd = get_lock_fd(filename, timeout) |
Check warning
Code scanning / CodeQL
File is not always closed Warning
Signed-off-by: Lukáš Doktor <[email protected]>
to avoid problems with NTP (or iffy clock sources) let's use time.monotonic() for time difference operations. Signed-off-by: Lukáš Doktor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for merging, debugging #147