client: Avoid double-cleanup exception #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in python <3.13 it raises FileNotFoundError, but python 3.13 seems to raise OSError exception instead when trying to unlock non-existing file. Signed-off-by: Lukáš Doktor <[email protected]>
Contributor
Author
|
@pevogam if I read the traceback correctly it seems python3.13 raises a different exception when the file was already deleted (forceful cleanup or multiple cleanup). Please let me know if there are any other issues as once this is resolved I'd like make a release as there were quite a few important changes already. |
Contributor
|
Awesome and thanks for pushing this! I will try it right away and report back by tomorrow (since our integration tests take a few solid hours). |
pevogam
approved these changes
Jun 18, 2025
Contributor
pevogam
left a comment
pevogam
left a comment
There was a problem hiding this comment.
Indeed, affected tests pass now and this change is easy enough to review and say yes to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in python <3.13 it raises FileNotFoundError, but python 3.13 seems to raise OSError exception instead when trying to unlock non-existing file.
Fixes: #147 (comment)