Skip to content

Conversation

@omps
Copy link

@omps omps commented Dec 15, 2017

updated packages for python 2.7

django version 1.11 is latest supported by python 2.7 version.

updated packages for python 2.7

django version 1.11 is latest supported by python 2.7 version.

* ``django``
* ``django``
Python 2.7 only supports django 1.11 please use:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not rendering well:
https://github.com/omps/avocado-server/blob/f4da01b618684b9525cffff76a52447583836b89/docs/source/Introduction.rst

Could you please improve the situation a bit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence "Python 2.7..." is being considered continuation line of the previous bullet item. Maybe the best solution would be:

* ``django`` (with Python 2.7, use ``django==1.11``) 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the whole paragraph is doomed to be outdated as the requirements.txt is the file that should be used to get dependencies. Currently there are hardcoded dependencies as it's being used by Travis, but we could create requirements-travis.txt and use >= and <= to specify the ranges.

@omps do you feel like doing this or should we change it ourselves? (basically it's about changing the docs to use pip install -r requirements.txt, cp requirements.txt requirements-travis.txt, changing .travis.yml to use requirements-travis.txt and then modifying requirements.txt to use ranges with python2 dependency (see https://github.com/avocado-framework/avocado/blob/master/requirements.txt for conditional deps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants