Skip to content

update iscsi.py module#4077

Merged
nickzhq merged 2 commits intoavocado-framework:masterfrom
nickzhq:multi_targets_iscsi
Jul 22, 2025
Merged

update iscsi.py module#4077
nickzhq merged 2 commits intoavocado-framework:masterfrom
nickzhq:multi_targets_iscsi

Conversation

@nickzhq
Copy link
Copy Markdown
Contributor

@nickzhq nickzhq commented Mar 12, 2025

  • Add a new class to supporting iscsi with the multi targets.
  • Update the create_iSCSI function.

ID: 3457

@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Mar 12, 2025

@qingwangrh Please take a look, thanks!

If it's failed on your machine, please save the test environment for me.

Thanks!

@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from 6fc1198 to a3bba1e Compare March 12, 2025 08:05
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Mar 12, 2025

Hello @YongxueHong @zhencliu , please take a review, thanks!

@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 2 times, most recently from f610b07 to 0c6a1e9 Compare March 13, 2025 03:54
@nickzhq nickzhq marked this pull request as draft March 13, 2025 11:28
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 5 times, most recently from 6c9b701 to 7d21bd8 Compare March 31, 2025 05:00
@nickzhq nickzhq marked this pull request as ready for review April 1, 2025 05:33
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 3 times, most recently from 8d3aa9a to 04d150d Compare April 1, 2025 05:42
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Apr 1, 2025

Hi @qingwangrh , please take a look, thanks!
If it's failed on your machine, please save the test environment for me.

Hi @zhencliu @YongxueHong please review this patch, if you guys find something strange( In other words, some codes are hard to understand. ), just let me know. Thanks!

Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
Comment thread virttest/iscsi.py Outdated
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 2 times, most recently from f39bf35 to 49be506 Compare April 7, 2025 12:15
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Apr 8, 2025

@zhencliu @YongxueHong Please take a look again, thanks!

@qingwangrh
Copy link
Copy Markdown
Contributor

Hi, @nickzhq could you please help introduce the usage?

@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Apr 14, 2025

Hi, @nickzhq could you please help introduce the usage?

Let me schedule a meeting later for usage.

@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 5 times, most recently from 887ea85 to 85f3ad0 Compare April 23, 2025 12:00
Comment thread virttest/shared/cfg/base.cfg Outdated
Comment thread virttest/iscsi.py
Comment thread virttest/iscsi.py
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from ea74da1 to e365191 Compare June 17, 2025 04:03
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Jun 17, 2025

@YongxueHong @zhencliu Please take a review, thanks!

Comment thread virttest/shared/cfg/base.cfg Outdated
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from e365191 to 1b98467 Compare July 1, 2025 04:13
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Jul 1, 2025

@YongxueHong @zhencliu Please take a review, thanks!

@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 2 times, most recently from 8cdebcd to 3b5572e Compare July 8, 2025 07:40
@nickzhq
Copy link
Copy Markdown
Contributor Author

nickzhq commented Jul 8, 2025

Hello @YongxueHong Please take a review, thanks!

@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from 3b5572e to 8cb290f Compare July 10, 2025 02:17
Copy link
Copy Markdown

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YongxueHong
Copy link
Copy Markdown

Hi @qingwangrh @zhencliu
Could you help review it since some updates to it?
Thanks in advance.

@YongxueHong YongxueHong requested a review from zhencliu July 10, 2025 02:53
Comment thread virttest/iscsi.py Outdated
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from 8cb290f to 8540180 Compare July 11, 2025 03:15
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch 5 times, most recently from 1e1b51c to e8f36be Compare July 15, 2025 08:27
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from e8f36be to 9833762 Compare July 21, 2025 08:17
nickzhq added 2 commits July 21, 2025 17:28
fix SyntaxWarning

Signed-off-by: Houqi (Nick) Zuo <hzuo@redhat.com>
Add Fileio class and MultiPathsIscsiLIO class to
map fileio model and target model.
Add MultiPathsIscsiLIOManager class to manage the
Fileio class and MultiPathsIscsiLIO class for user.
Add the create_iSCSI function to support the new class.

Signed-off-by: Houqi (Nick) Zuo <hzuo@redhat.com>
@nickzhq nickzhq force-pushed the multi_targets_iscsi branch from 9833762 to 6909682 Compare July 21, 2025 11:29
@qingwangrh
Copy link
Copy Markdown
Contributor

LGTM

@nickzhq nickzhq merged commit ff8b333 into avocado-framework:master Jul 22, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants