disk.py: add elements of ssh/https network disk#4083
Merged
Yingshun merged 1 commit intoavocado-framework:masterfrom Apr 28, 2025
Merged
disk.py: add elements of ssh/https network disk#4083Yingshun merged 1 commit intoavocado-framework:masterfrom
Yingshun merged 1 commit intoavocado-framework:masterfrom
Conversation
1. Add the new elements for disk source: - knownHosts - identity - ssl - readahead - timeout - cookies 2. Add storage_use_nbdkit which can be used with ssh/https network disks in utils_config.py. Signed-off-by: meinaLi <meili@redhat.com>
Contributor
Author
|
This update is related to autotest/tp-libvirt#6251 and autotest/tp-libvirt#6252. |
Contributor
Author
|
@chloerh Please help review this PR, thanks. |
chloerh
reviewed
Apr 11, 2025
Contributor
chloerh
left a comment
There was a problem hiding this comment.
The code looks good, could you please provide a result of setup_attrs() and fetch_attrs() which could be helpful, thanks!
Contributor
Author
|
The fetch_attrs() result for ssh network disk: The setup_attrs() result for ssh network disk: |
Contributor
Author
|
The fetch_attrs() result for https network disk: The setup_attrs() result for https network disk: |
Contributor
Author
|
@Yingshun Can you help review this PR? It's related to tp-libvirt PR which is in reviewing. This one need to be merged early than others. Thanks. |
Yingshun
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.