vm_xml:func sync() set ignore_status=True when trying to define vm#4084
Merged
Yingshun merged 1 commit intoavocado-framework:masterfrom Apr 16, 2025
Merged
vm_xml:func sync() set ignore_status=True when trying to define vm#4084Yingshun merged 1 commit intoavocado-framework:masterfrom
Yingshun merged 1 commit intoavocado-framework:masterfrom
Conversation
virsh instance of virsh.Virsh has ignore_status set to False by default which would cause the failure of define in function sync() with wrong xml and could not revert to the original xml. Signed-off-by: Haijiao Zhao <haizhao@redhat.com>
Yingshun
approved these changes
Mar 21, 2025
nanli1
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virsh instance of virsh.Virsh has ignore_status set to False by default which would cause the failure of define in function sync() with wrong xml and could not revert to the original xml.